Skip to content

Removed unnecessary function argument #26771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 1 commit into from
Feb 13, 2020
Merged

Removed unnecessary function argument #26771

magento-engcom-team merged 1 commit into from
Feb 13, 2020

Conversation

@ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Feb 8, 2020 •
edited
Loading

Description (*)

Code Improvement:
Removed unnecessary function argument passed in the _canReorder function.

The reason to remove the argument is _canReorder function definition has set a default value the argument.
Below is the reference code:

magento2/app/code/Magento/Sales/Model/Order.php

Line 881 in 4b78d9a

protected function _canReorder($ignoreSalable = false)

Manual testing scenarios (*)

  1. Checked re-order functionality in the storefront after changed the code, the functionality is working as expected.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned aleron75 Feb 11, 2020
@aleron75 aleron75 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup and removed Progress: ready for testing labels Feb 11, 2020
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 11, 2020

Hi @aleron75, thank you for the review.
ENGCOM-6850 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Feb 11, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 11, 2020

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Feb 11, 2020
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Feb 12, 2020

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.
image

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2020
@slavvka
ENGCOM-6850: Removed unnecessary function argument #26771
e608fc0
@magento-engcom-team magento-engcom-team merged commit 7d695bd into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov Awaiting requested review from sidolov

@dmytro-ch dmytro-ch Awaiting requested review from dmytro-ch

@06romix 06romix Awaiting requested review from 06romix

1 more reviewer

@aleron75 aleron75 aleron75 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aleron75 aleron75

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Sales Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ajithkumar-maragathavel @magento-engcom-team @engcom-Alfa @engcom-Charlie @aleron75